Opened 10 years ago

Closed 10 years ago

#131 closed task (fixed)

review: a minor cleanup for MapElement constructor

Reported by: jinmei Owned by: jelte
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please review r1673. This is a minor cleanup and should be trivial.

I'm giving this to Jelte.

Subtickets

Change History (2)

comment:1 follow-up: Changed 10 years ago by jelte

  • Status changed from new to accepted

Change is correct, though I'll have to mention that I intend to remove this constructor as part of the changes intended in ticket #124 (also because of the correct remark that it can now throw an exception while it shouldn't, as remarked in ticket #129)

comment:2 in reply to: ↑ 1 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from accepted to closed

Replying to jelte:

Change is correct, though I'll have to mention that I intend to remove this constructor as part of the changes intended in ticket #124 (also because of the correct remark that it can now throw an exception while it shouldn't, as remarked in ticket #129)

Understood. Closing this ticket anyway.

Note: See TracTickets for help on using tickets.