Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1309 closed task (complete)

auth NSEC support: Handle WILDCARD and WILDCARD_CNAME

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: Sprint-20111108
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket:
Total Hours: 2:35 Internal?: no

Description

This is subtask 5 of #1244. Depend on #1305.

Subtickets

Change History (12)

comment:1 Changed 8 years ago by jelte

  • Add Hours to Ticket changed from 0 to 6

comment:2 Changed 8 years ago by jelte

  • Add Hours to Ticket 6 deleted
  • Estimated Difficulty changed from 0 to 5

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20111025 to Sprint-20111108

comment:4 Changed 8 years ago by jinmei

  • Owner set to jinmei
  • Status changed from new to accepted

comment:5 Changed 8 years ago by jinmei

Branch trac1309 is ready for review. It should be straightforward.

comment:6 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from accepted to reviewing

comment:7 Changed 8 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:8 follow-up: Changed 8 years ago by jelte

  • Owner changed from jelte to jinmei

Looks good, this can be merged

Technically, the comment at the end of the switch statement (for the default case) is not entirely true anymore, as WILDCARD is now handled :)

comment:9 in reply to: ↑ 8 Changed 8 years ago by jinmei

Replying to jelte:

Looks good, this can be merged

Okay, thanks for the review.

Technically, the comment at the end of the switch statement (for the default case) is not entirely true anymore, as WILDCARD is now handled :)

Ah, right, good catch. Actually, there's sill one unsupported code:
WILDCARD_NXRRSET, but it will soon be supported, too, so I revised
the comment as follows:

                // This is basically a bug of the data source implementation,
                // but could also happen in the middle of development where
                // we try to add a new result code.

so that it will be true after we add the support for WILDCARD_NXRRSET
(and is even true now).

I'm going to merge this branch with this update, and close the ticket.

comment:10 Changed 8 years ago by jinmei

  • Resolution set to complete
  • Status changed from reviewing to closed

comment:11 Changed 8 years ago by jinmei

  • Total Hours changed from 0 to 2:35

comment:12 Changed 8 years ago by jinmei

(I've been keeping track of time I spend for each socket using https://www.toggl.com/. As an experimental practice I'll
also record the time on trac ticket when I complete the task)

Note: See TracTickets for help on using tickets.