Opened 8 years ago

Closed 8 years ago

#1308 closed task (fixed)

auth NSEC support: Handle WILDCARD_EMPTY case

Reported by: jinmei Owned by: kevin_tes
Priority: medium Milestone: Sprint-20111206
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: NSEC
Estimated Difficulty: 3 Add Hours to Ticket:
Total Hours: 0.75 Internal?: no

Description

This is subtask 4 of #1244. Depend on #1305.

Subtickets

Change History (20)

comment:1 Changed 8 years ago by jinmei

  • Milestone changed from New Tasks to Sprint-20111025

comment:2 Changed 8 years ago by jinmei

As noted in http://bind10.isc.org/ticket/1305#comment:3,
we probably don't need to handle this case separately from
WILDCARD_NXRRSET, because in either case what we should do is the
same: perform find() again with NO_WILDCARD for the original query
name (i.e. the name before wildcard expansion), confirm it results
in NXDOMAIN, and adds the returned NSEC to the authority section.

But we should still test both cases separately as how we end up these cases
is still different.

comment:3 Changed 8 years ago by jelte

  • Add Hours to Ticket changed from 0 to 4

comment:4 Changed 8 years ago by jelte

  • Add Hours to Ticket 4 deleted
  • Estimated Difficulty changed from 0 to 3

comment:5 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20111025 to Sprint-20111108

comment:6 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20111108 to Sprint-20111122

comment:7 Changed 8 years ago by kevin_tes

  • Owner set to kevin_tes
  • Status changed from new to accepted

comment:8 Changed 8 years ago by kevin_tes

  • Owner changed from kevin_tes to UnAssigned
  • Status changed from accepted to reviewing

comment:9 Changed 8 years ago by kevin_tes

This ticket is ready for the review.

comment:10 Changed 8 years ago by shane

  • Feature Depending on Ticket set to NSEC

comment:11 follow-up: Changed 8 years ago by jinmei

I only took a quick glance of the diff, but do we really need
to define and use WILDCARD_EMPTY? Was there any case where
WILDCARD_NXRRSET wasn't sufficient?

comment:12 in reply to: ↑ 11 Changed 8 years ago by kevin_tes

Replying to jinmei:

I only took a quick glance of the diff, but do we really need
to define and use WILDCARD_EMPTY? Was there any case where
WILDCARD_NXRRSET wasn't sufficient?

Yes,WILDCARD_NXRRSET can handle WILDCARD_EMPTY, from this point it does not need to define WILDCARD_EMPTY, and there is no sufficient problem for using WILDCARD_NXRRSET.
On my opinion defining WILDCARD_EMPTY just makes it clear to developers.

comment:13 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:14 follow-up: Changed 8 years ago by vorner

  • Owner changed from vorner to kevin_tes

Hello

I fixed few style fixes (spaces at the end of lines, wrapping, probably more than you introduced) and pushed. I hope you don't mind.

And, while I don't see a problem in having a separate status for empty wildcard, I'd like to point out that it is not currently returned by the database backend. If you want to introduce this status code, it should be also used.

Thanks

comment:15 in reply to: ↑ 14 Changed 8 years ago by kevin_tes

Replying to vorner:

Hello

I fixed few style fixes (spaces at the end of lines, wrapping, probably more than you introduced) and pushed. I hope you don't mind.

vorner,thanks very much for the effort. I'd like to see those were fixed.

And, while I don't see a problem in having a separate status for empty wildcard, I'd like to point out that it is not currently returned by the database backend. If you want to introduce this status code, it should be also used.

I am not so sure how will it affect the "return by the database backend". On this point of view, i'd like to remove this status.

Thanks

comment:16 Changed 8 years ago by kevin_tes

The changes have done(used WILDCARD_NXRRSET instead),and pushed ,please review it.
Thanks.

comment:17 Changed 8 years ago by kevin_tes

  • Owner changed from kevin_tes to vorner

comment:18 Changed 8 years ago by vorner

  • Owner changed from vorner to kevin_tes
  • Total Hours changed from 0 to 0.75

Hello

It looks OK. Please merge.

Thanks

comment:19 Changed 8 years ago by kevin_tes

merged to master,closed.

comment:20 Changed 8 years ago by kevin_tes

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.