Opened 8 years ago

Closed 6 years ago

#1304 closed defect (wontfix)

xfrin test should retrieve config defaults from the spec file

Reported by: jinmei Owned by:
Priority: medium Milestone: DNS Outstanding Tasks
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 5 Add Hours to Ticket:
Total Hours: 0 Internal?: no

Description

Right now, it's hardcording some default values, which just happen to
be consistent with the spec file:

class MockCC():
    def get_default_value(self, identifier):
        # The returned values should be identical to the spec file
        # XXX: these should be retrieved from the spec file
        # (see MyCCSession of xfrout_test.py.in)
        if identifier == "zones/master_port":
            return TEST_MASTER_PORT
        if identifier == "zones/class":
            return TEST_RRCLASS_STR
        if identifier == "zones/use_ixfr":
            return False

Obviously it's ugly and more difficult to maintain. As commented the
mock class should retrieve the defaults from the spec file. We should
also have some tests to check whether the default values are really
used in other cases (such as "max transfer in").

Subtickets

Change History (6)

comment:1 Changed 8 years ago by jelte

  • Add Hours to Ticket changed from 0 to 5

comment:2 Changed 8 years ago by jelte

  • Add Hours to Ticket 5 deleted
  • Estimated Difficulty changed from 0 to 5

comment:3 Changed 8 years ago by jelte

  • Milestone changed from Next-Sprint-Proposed to New Tasks

comment:4 Changed 8 years ago by shane

  • Milestone New Tasks deleted

comment:5 Changed 6 years ago by stephen

  • Milestone set to DNS Outstanding Tasks

comment:6 Changed 6 years ago by tomek

  • Resolution set to wontfix
  • Status changed from new to closed

DNS and BIND10 framework is outside of scope for Kea project.
The corresponding code has been removed from Kea git repository.
If you want to follow up on DNS or former BIND10 issues, see
http://bundy-dns.de project.

Closing ticket.

Note: See TracTickets for help on using tickets.