Opened 8 years ago

Closed 8 years ago

#1294 closed task (complete)

really disable IXFR by default

Reported by: jinmei Owned by: UnAssigned
Priority: very high Milestone: Sprint-20111025
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

so that it will be disabled (for now) by default in the most
common configuration for secondaries, where both the zonemgr and
xfrin have configurations of secondary zones.

It will also make the documentation less confusing.

Plan is to make it in this week's release.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by jinmei

trac1294 is ready for review. The plan is to include this in the
next release, so if we miss that deadline this ticket should be
removed from the current sprint.

comment:2 Changed 8 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:3 Changed 8 years ago by jelte

commenting just on the code; the initializer has an imcomplete comment 'we should retrieve it from the', when ixfr_disabled is None. Then it calls set_ixfr_disabled(), which itself also has the None check (and it appears that one actually does look up the default from the spec), so the comment and check in the initializer seems unnecessary

comment:4 Changed 8 years ago by jelte

upon jeremy's request, i changed the name of the setting to 'use_ixfr', and reversed its interpretation.

It defaults to False, and if False, xfrin will do AXFR.

Updated tests and docs for this as well

comment:5 Changed 8 years ago by jelte

pushed another change to this branch; IXFR was only done on 'retransfer' and 'refresh' commands, not on 'notify'... (if anything, it should probably do axfr always on retransfer, idk why refresh and notify are separate actions)

comment:6 Changed 8 years ago by jinmei

Thanks for the prompt review.

I made a couple of final cleanups, and after checking them with jeremy merged it to master.

Closing ticket. I'll give an estimation of 2 to this ticket.

comment:7 Changed 8 years ago by jinmei

  • Estimated Difficulty changed from 0 to 2
  • Resolution set to complete
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.