Opened 8 years ago

Closed 8 years ago

#1285 closed defect (fixed)

[critical] wrong install directory for isc.dns.__init__.py

Reported by: jinmei Owned by: jinmei
Priority: very high Milestone: Sprint-20111011
Component: xfrin Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See the attached patch.

This must be fixed before the next release, so I'm putting this
to the current sprint. I also specify this as a blocker. Please
review it ASAP.

Without the change, init.py will be installed $(pyexecdir), e.g.
/some_path/python3.1/site-packages. It's not a new bug, but
hasn't caused an actual disruption because we haven't relied on it
from installed programs. Now isc.xfrin.diff refers to isc.dns, so
without correcting init.py xfrin will fail to start up.

p.s. we should probably also consider whether we'll keep both pydnspp
and isc.dns (the latter is a mere forwarder for the former), but
that's not an urgent issue.

Subtickets

Attachments (1)

diff (305 bytes) - added by jinmei 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by jinmei

comment:1 Changed 8 years ago by jinmei

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:2 Changed 8 years ago by jinmei

Although it's a very small fix I think we need a changelog entry because
it would be better to note that the wrong init.py should be removed.

This is the proposed entry:

296.?	[bug]		jinmei
	__init__.py for isc.dns was installed in the wrong directory,
	which would now make xfrin fail to start.  It was also bad
	in that it replaced any existing __init__.py in th public
	site-packages directory.  After applying this fix You may want to
	check if the wrong init file is in the wrong place, in which
	case it should be removed.
	(Trac #1285, git TBD)

comment:3 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:4 follow-up: Changed 8 years ago by vorner

  • Owner changed from vorner to jinmei

Hello

I see the problem and this should fix it. I should test the real program from time to time. Please merge.

Thanks

comment:5 in reply to: ↑ 4 Changed 8 years ago by jinmei

Replying to vorner:

I see the problem and this should fix it. I should test the real program from time to time. Please merge.

Thanks for the prompt check. Merged, closing. I'll give an estimation
of 2 to this ticket.

comment:6 Changed 8 years ago by jinmei

  • Estimated Difficulty changed from 0 to 2

comment:7 Changed 8 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.