Opened 10 years ago

Closed 10 years ago

#128 closed defect (fixed)

review: fix exception unsafe bug in lib/cc/data.cc

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please someone confirm r1664.

It fixes a minor exception (un)safe bug: the construction of resulting string can throw an exception (though very unlikely), in which case the newly allocated buffer will leak.

This fix includes other cleanups. See the commit log message.

Subtickets

Change History (5)

comment:1 Changed 10 years ago by shane

  • Summary changed from fix exception unsafe bug in lib/cc/data.cc to review: fix exception unsafe bug in lib/cc/data.cc

comment:2 Changed 10 years ago by jreed

  • Status changed from new to reviewing

comment:3 Changed 10 years ago by shane

  • Owner changed from UnAssigned to shane
  • Status changed from reviewing to accepted

comment:4 follow-up: Changed 10 years ago by shane

  • Owner changed from shane to jinmei
  • Status changed from accepted to assigned

The code changes look good.

comment:5 in reply to: ↑ 4 Changed 10 years ago by jinmei

  • Resolution set to fixed
  • Status changed from assigned to closed

Replying to shane:

The code changes look good.

It has been already committed to the trunk. Simply closing the ticket.

Note: See TracTickets for help on using tickets.