Changes between Initial Version and Version 1 of Ticket #1228, comment 11


Ignore:
Timestamp:
Nov 6, 2011, 10:04:47 AM (8 years ago)
Author:
tomek
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1228, comment 11

    initial v1  
    6363Hmmm. Maybe better approach would be to modify this method a bit, so len would mean "give me at most X bytes". If there are less bytes available, just send that.
    6464
    65 In the current form, I prefer to leave the test as it is. Otherwise we don't have such guarantee you mentioned. This operation is sufficiently trivial to consider is atomic - completely succeeds or completely fails. The only think we would have gained in removing this if statement is just a couple of bytes of compiled code.
     65In the current form, I prefer to leave the test as it is. Otherwise we don't have such guarantee you mentioned. This operation is sufficiently trivial to consider is atomic - completely succeeds or completely fails. The only thing we would have gained in removing this if statement is just a couple of bytes of compiled code.
    6666
    6767Changes pushed. commit-id 5d6c71aeb2575883488b2cde87501aa84260b1ab