Opened 10 years ago

Closed 10 years ago

#119 closed defect (fixed)

review: fixes to autoconf.ac for older versions of automake

Reported by: jinmei Owned by: jreed
Priority: low Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

Please review r1622.

Before this patch, --with-pythonpath didn't work well for older versions of automake that can't handle python3 well. The following variable settings used AM_PYTHON_CHECK_VERSION, but older automake versions of this macro didn't work correctly for python3. This broke the original purpose of --with-pythonpath.

I've also made a change from print() to sys.stdout.write() because the former doesn't work for python2. So if the user accidentally specified python2 with --with-pythonpath, something unexpected happen.

Further, I modified pythondir and pyexecdir settings not to hardcode "3.1". It's very fragile once python 3.2 is released.

I believe the best reviewer is Jeremy, so I'm giving this ticket to him.

Subtickets

Change History (1)

comment:1 Changed 10 years ago by jreed

  • Resolution set to fixed
  • Status changed from new to closed

This looks good. And appears to be working fine. Closing this ticket. (Note I didn't merge any of this to reviewed branch because don't have configure.ac there yet.)

Note: See TracTickets for help on using tickets.