Opened 8 years ago

Closed 8 years ago

#1161 closed enhancement (wontfix)

LIBADD/LDADD on debian/ubuntu

Reported by: jelte Owned by: jelte
Priority: medium Milestone: Sprint-20111025
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

see message https://lists.isc.org/pipermail/bind10-dev/2011-August/002535.html

If we can override the deplibs value on these systems, we don't need those thousands of LDADD lines (and can probably fix some other issues we now work around as well)

Subtickets

Change History (10)

comment:1 Changed 8 years ago by stephen

  • Milestone changed from Next-Sprint-Proposed to Sprint-20110816

comment:2 Changed 8 years ago by jelte

  • Estimated Difficulty changed from 0 to 2

comment:3 Changed 8 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:4 Changed 8 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

OK, I've added a few lines to configure.ac that sets it to 'yes' if it is 'no' (with an option not to do that).

Turns out the actual linker hint flags it saves us isn't *that* much (somewhere between 30 and 40), since a lot of our code either uses most of the libs (auth/resolver), or directly pokes into them (as much tests do).

So if we decide we don't want this i can understand. It might help should we need a feature from one lib in another, and we don't want to update all binary makefiles.

comment:5 Changed 8 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:6 Changed 8 years ago by stephen

  • Owner changed from stephen to jelte

Seems OK. However:

  • The changes to the Makefile.am files are somwehat timid, generally removing just one or two libraries from the link command line? Isn't it possible to be a bit more agressive?
  • On Ubuntu, if the option --disable-libtool-update-deplibs is given, although the libraries compile, the removal of some dependencies in Makefile.am will cause the tests to fail. With this in mind, is the option worth having?

comment:7 Changed 8 years ago by jelte

Yes the changes are less than what i had originally thought they would be. I since then started wondering whether it was worth it.

If we do put this in, I think the option to disable it *may* be useful, just not for current ubuntu :)

comment:8 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20110927 to Sprint-20111011

comment:9 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20111011 to Sprint-20111025

comment:10 Changed 8 years ago by jelte

  • Resolution set to wontfix
  • Status changed from reviewing to closed

Okay this ticket stuck around too long, and I am underwhelmed by the advantages it brings, so I'm canceling it.

Note: See TracTickets for help on using tickets.