Opened 9 years ago

Closed 8 years ago

#1140 closed task (complete)

RR type implementation: SPF

Reported by: shane Owned by: dvv
Priority: medium Milestone: Sprint-20111011
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Implement the SPF type, from RFC 4408. This is in active use in DNS servers today, so I am giving it a priority "major".

See ticket #809 for more discussion.

Subtickets

Change History (25)

comment:1 Changed 9 years ago by stephen

  • Milestone changed from Next-Sprint-Proposed to Sprint-20110802

comment:2 Changed 9 years ago by dvv

  • Owner changed from UnAssigned to dvv
  • Status changed from new to accepted

comment:3 Changed 9 years ago by jinmei

  • Type changed from defect to task

comment:4 Changed 9 years ago by dvv

  • Owner changed from dvv to UnAssigned
  • Status changed from accepted to reviewing

re-done txt and created spf to use a common template base

comment:5 Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to zzchen_pku

comment:6 Changed 9 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 4

comment:7 Changed 9 years ago by zzchen_pku

  • Why should we keep two empty .cc files(spf_99.cc, txt_16.cc)?
  • What's the usage of them? Do we need them?
    friend class TXT_LIKE<TXT, 16>; 
    static string const id;         
    
  • Do we consider to implement multi character-string now?
  • I think comments are required for class TXT_LIKE, purpose, usage, etc.
Last edited 9 years ago by zzchen_pku (previous) (diff)

comment:8 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

comment:9 Changed 9 years ago by dvv

  • Owner changed from dvv to zzchen_pku

A cleanup along the lines of my latest fixes in #1144. The unneeded files removed, the rudiments of experimentation deleted.

Makefile.am fixed.

Still working on comments and tests.

I tried to make the source comply with the coding guidelines, but I'm sure I've missed something (or a lot). Please let me know what I missed.

comment:10 Changed 9 years ago by dvv

  • Owner changed from zzchen_pku to dvv
  • Status changed from reviewing to accepted

after discussing #1144 with jinmei, reassigned it back to myself

comment:11 Changed 9 years ago by dvv

  • Owner changed from dvv to zzchen_pku
  • Status changed from accepted to reviewing

TXT&SPF re-done to isolate the implementation details in txt_like.h from rdataclass.h using private pointers.

comment:12 Changed 9 years ago by dvv

and I'm still working on docs and tests

comment:13 Changed 9 years ago by zzchen_pku

  • Milestone changed from Sprint-20110830 to Sprint-20110816
  • Owner changed from zzchen_pku to dvv

The change looks okay for me.
But we still need to fix identation, line length(Lines should not be longer than 79 characters according to coding style) issues.

And waiting for docs and tests:)

comment:14 Changed 9 years ago by zzchen_pku

  • Milestone changed from Sprint-20110816 to Sprint-20110830
  • Owner changed from dvv to zzchen_pku

comment:15 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

Update milestone:)

comment:16 Changed 9 years ago by dvv

  • Owner changed from dvv to zzchen_pku

done style fixes. hope it looks better now :-)

comment:17 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

Looks okay:)
Please go ahead and work on docs and tests.

comment:18 follow-up: Changed 9 years ago by dvv

  • Owner changed from dvv to zzchen_pku

Documentation added to spf_99.{h,cc} and detail/txt_like.h

comment:19 in reply to: ↑ 18 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

Replying to dvv:

Documentation added to spf_99.{h,cc} and detail/txt_like.h

Looks okay, but it seems there are some duplicated comments occurs in both spf_99.h and spf_99.cc, I personally don't think it is necessary to keep both :)

How about the unittest?

comment:20 follow-up: Changed 8 years ago by dvv

  • Owner changed from dvv to zzchen_pku

unittest added

comment:21 in reply to: ↑ 20 Changed 8 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

Replying to dvv:

unittest added

  • The inclusion of below headers in rdata_txt_like_unittest.cc seems unnecessary if i'm reading this correctly.
    #include <dns/messagerenderer.h>
    #include <dns/rdata.h>   
    #include <dns/rrclass.h> 
    #include <dns/rrtype.h>
    
  • shouldn't we also test assignment, toWireRenderer and compare interfaces?

comment:22 Changed 8 years ago by jelte

  • Milestone changed from Sprint-20110927 to Sprint-20111011

comment:23 Changed 8 years ago by dvv

  • Owner changed from dvv to zzchen_pku

comment:22 addressed

comment:24 Changed 8 years ago by zzchen_pku

  • Owner changed from zzchen_pku to dvv

I pushed one copyright and style fix.
The rest looks ok, please merge.

comment:25 Changed 8 years ago by dvv

  • Resolution set to complete
  • Status changed from reviewing to closed

merged into master

Note: See TracTickets for help on using tickets.