Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1096 closed task (fixed)

change default of handle_logging_config in ModuleCCSession

Reported by: jelte Owned by: jelte
Priority: medium Milestone: Sprint-20110802
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by vorner)

now that (almost) all modules have been converted to the new logging, i think we should change the default constructor argument of ModuleCCSession.

If we don't, we need to set the add an argument true in src/bin/auth/main.cc, since the auth module does not use the configuration in Logging right now.

It is not a large task; make the default true, and remove the optional argument in the various modules.

Subtickets

Change History (7)

comment:1 Changed 9 years ago by shane

  • Milestone changed from New Tasks to Next-Sprint-Proposed
  • Type changed from defect to task

comment:2 Changed 9 years ago by stephen

  • Milestone changed from Next-Sprint-Proposed to Sprint-20110802

comment:3 Changed 9 years ago by jelte

  • Owner set to UnAssigned
  • Status changed from new to reviewing

ready for review. The code changes themselves are pretty small (changed the defaults from false to true, then removed all the constructor call arguments where the values now match the defaults), but the diff got a bit bigger since the tests had a lot of constructor calls that now needed the explicit false argument.

comment:4 Changed 9 years ago by vorner

  • Description modified (diff)
  • Owner changed from UnAssigned to vorner

comment:5 Changed 9 years ago by vorner

  • Owner changed from vorner to jelte

It seems OK, please merge.

comment:6 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

thanks, merged, closing ticket.

comment:7 Changed 9 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 2
Note: See TracTickets for help on using tickets.