Opened 9 years ago

Closed 9 years ago

#1077 closed enhancement (complete)

Update descriptions of logging code messages

Reported by: stephen Owned by: stephen
Priority: very low Milestone: Sprint-20110712
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 2.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by vorner)

From this email:

LOGIMPL_ABOVEDBGMAX and BELOWDBGMIN have typo "DEBGUGn" -- what is this string? Where documented? Is this used by admins too? If developer only, should message for "BADDEBUG" say to open a bug ticket?

MSG_BADSEVERITY allow "NONE" also?

MSG_BADSTREAM incomplete description.

MSG_DUPLNS Where is $NAMESPACE directive documented?

MSG_DUPMSGID, MSG_IDNOTFND, MSG_NOMSGID, MSG_INVMSGID, MSG_NOMSGTXT (maybe MSG_NSINVARG and MSG_NSNOARG and MSG_NSEXTRARG too?) (maybe MSG_PRFEXTRARG and MSG_PRFINVARG too?): maybe there should be a developer option to kill BIND 10 startup if this happens.

MSG_INVMSGID incomplete description

MSG_IDNOTFND multiple paragraph description okay?

should the developer MSG_ problems say to open a bug ticket report?

Subtickets

Change History (7)

comment:1 Changed 9 years ago by stephen

A recent update top the logging messages made changes that should have addressed most of these issues. (It also changed the message prefix to LOG_) This ticket has been raised as a check that all the issues listed here have been fixed.

comment:2 Changed 9 years ago by stephen

  • Owner set to stephen
  • Status changed from new to assigned

comment:3 Changed 9 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from assigned to reviewing

As noted, a number of the problems were already fixed in an earlier ticket:

src/lib/log/logimpl_messages.mes

LOGIMPL_ABOVEDBGMAX and BELOWDBGMIN have typo "DEBGUGn" -- what is this string? Where documented? Is this used by admins too? If developer only, should message for "BADDEBUG" say to open a bug ticket?

Already fixed.

src/lib/log/log_messages.mes
(Note that a previous ticket changed the prefix from MSG_ to LOG_)

MSG_BADSEVERITY allow "NONE" also?

Added "NONE".

MSG_BADSTREAM incomplete description.

Updated.

MSG_DUPLNS Where is $NAMESPACE directive documented?

In the README file in the src/lib/log directory. ($NAMESPACE is only of interest to developers.) However, the description has been updated.

MSG_DUPMSGID, MSG_IDNOTFND, MSG_NOMSGID, MSG_INVMSGID, MSG_NOMSGTXT (maybe MSG_NSINVARG and MSG_NSNOARG and MSG_NSEXTRARG too?) (maybe MSG_PRFEXTRARG and MSG_PRFINVARG too?): maybe there should be a developer option to kill BIND 10 startup if this happens.

MSG_NOMSGID, MSG_INVMSGID, MSG_NOMSGTXT, MSG_NSINVARG, MSG_NSNOARG, MSG_NSEXTRARG, MSG_PRFEXTRARG and MSG_PRFINVARG (actually, their LOG_ equivalents) only apply to the message compiler. This is used in the build process, and any errors in that soon become apparent.

MSG_DUPMSGID (now LOG_DUPLICATE_MESSAGE_ID) indicates that multiple symbols of the same name have been detected. A new ticket (#1093) has been raised for the suggestion that the condition cause the program to terminate.

MSG_IDNOTFND (now LOG_NO_SUCH_MESSAGE) is generated when a local message file is read but an ID in it does not correspond to one of the compiled-in IDs. This is most likely a typo in the local message file, so it is a warning and does not cause BIND 10 to exit.

MSG_INVMSGID incomplete description

Updated in a previous ticket.

MSG_IDNOTFND multiple paragraph description okay?

Yes.

should the developer MSG_ problems say to open a bug ticket report?

Done in a previous ticket.

comment:4 Changed 9 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 2

comment:5 Changed 9 years ago by vorner

  • Description modified (diff)
  • Owner changed from UnAssigned to vorner

comment:6 Changed 9 years ago by vorner

  • Owner changed from vorner to stephen

As with #1078, is „log a bug report“ OK? I find „file a bug report“ more common. Otherwise it is OK to merge.

With regards

comment:7 Changed 9 years ago by stephen

  • Resolution set to complete
  • Status changed from reviewing to closed

Changed "log a bug report" to "submit a bug report". Merged in commit b5bbfb2f868f8f7401018debe275c39fc65a5139

Note: See TracTickets for help on using tickets.