Opened 9 years ago

Closed 9 years ago

#1065 closed task (complete)

support empty node in DatabaseZoneHandle::find().

Reported by: jinmei Owned by: vorner
Priority: medium Milestone: Sprint-20110830
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 4.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no


See commit 76e684704466abf66792b79582c716b83ff4da5b of trac817a for
prototype implementation.

(but the actual implementation doesn't have to stick to the way that
the prototype does)

This task depends on #1060, #1061, #1062 (but can be done in parallel
with other find() support tasks).


Change History (7)

comment:1 Changed 9 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 4

comment:2 Changed 9 years ago by stephen

  • Milestone changed from Next-Sprint-Proposed to Sprint-20110816

comment:3 Changed 9 years ago by vorner

  • Owner set to vorner
  • Status changed from new to accepted

comment:4 Changed 9 years ago by vorner

  • Owner changed from vorner to UnAssigned
  • Status changed from accepted to reviewing


I chose to go the way in the experimental branch, since it looks simple and I believe part of the code will be possible to be used for the wildcard match (but I didn't think about it yet). It should be ready for review.

comment:5 Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to zzchen_pku

comment:6 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to vorner

Looks okay, please go ahead and merge.
By the way, should we provide a ChangeLog? entry for it?

comment:7 Changed 9 years ago by vorner

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks, merged.

No, I believe this one doesn't need a changelog entry, as the new code is not used by anything yet. There'll be one big changelog entry for all the refactoring when we switch from the old datasource to the new one.

Note: See TracTickets for help on using tickets.