Opened 8 years ago

Closed 8 years ago

#1057 closed defect (fixed)

acl test doesn't compile due to duplicate symbol

Reported by: jinmei Owned by: jinmei
Priority: very high Milestone: Sprint-20110628
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It failed in my environment (MacOS X + clang++):

ld: duplicate symbol __ZTIN12_GLOBAL__N_116TestCreatorErrorE$non_lazy_pointer in .libs/run_unittests and .libs/run_unittests

From a quick check, I found some problematic practices in acl/tests/creator.h:

  • 'using namespace' in the top level of the header file
  • use unnamed namespace in the header file

Not yet really sure if this is the reason for the linker error, but
it's better to be fixed. Hopefully it will fix the linker the issue, too.

The fix should be straightforward, but will require a certain amount of
code, so I'm creating a separate ticket for placeholder.

Subtickets

Change History (7)

comment:1 Changed 8 years ago by jinmei

Suggested fix was committed in trac1057. Please review.

I've also added this to Makefile.am:

AM_CXXFLAGS = $(B10_CXXFLAGS)

as noted in the commit log, without this we'd lose many -Wxxx flags.

comment:2 Changed 8 years ago by jinmei

  • Estimated Difficulty changed from 0.0 to 1.0

comment:3 Changed 8 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

comment:4 Changed 8 years ago by jinmei

As it couldn't get reviewed before everyone else went to bed,
I made another set of changes. See the commit log for the rationale.

I believe this fix must be in the next release.

comment:5 follow-up: Changed 8 years ago by vorner

  • Owner changed from UnAssigned to jinmei

Thank you for the fix, I should be less lazy to do it properly next time. Please, merge.

comment:6 in reply to: ↑ 5 Changed 8 years ago by jinmei

Replying to vorner:

Thank you for the fix, I should be less lazy to do it properly next time. Please, merge.

No problem, and thanks for the check. Merged, closing ticket.

comment:7 Changed 8 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.