Opened 9 years ago

Closed 6 years ago

#1052 closed defect (fixed)

B10_LOGGER_SEVERITY and B10_LOGGER_DBGLEVEL ignored or no complaint if bogus values

Reported by: jreed Owned by: UnAssigned
Priority: medium Milestone: Sprint-20131015
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I set B10_LOGGER_SEVERITY and B10_LOGGER_DBGLEVEL to various real and bogus values but don't see any change in output and no errors if they are bogus.

This may be related to #1051 (maybe that one does have an error but just never gets to that code path).

Subtickets

Change History (5)

comment:1 Changed 9 years ago by shane

  • Defect Severity changed from N/A to Medium
  • Milestone changed from New Tasks to Year 3 Task Backlog

comment:2 Changed 8 years ago by shane

  • Milestone Year 3 Task Backlog deleted
  • Owner set to jreed
  • Status changed from new to assigned

B10_LOGGER_DBGLEVEL does not seem to get used anywhere in the code. I don't propose removing it on this ticket because we have a policy not to remove old symbols, and I think our ticket on a tool for auditing the logging will catch this and others not in use.

I'm not sure about LOGGER_SEVERITY... have you tried setting this recently? Do we still allow bogus value?

comment:3 Changed 6 years ago by stephen

The B10_LOGGER_* environment variables allow the setting of logging parameters in unit tests - they are not used by the main BIND 10 code. See src/lib/log/logger_unittest_support.h for more details.

If the values are incorrect, an error message describing the problem should appear before the test output.

comment:4 Changed 6 years ago by muks

  • Milestone set to Sprint-20131015
  • Owner changed from jreed to UnAssigned
  • Status changed from assigned to reviewing

B10_LOGGER_SEVERITY's value is checked in logger_level.cc in getSeverity() and if it is a bogus value, en error is logged and INFO severity is used after that.

B10_LOGGER_DBGLEVEL's value is checked in logger_unittest_support.cc in b10LoggerDbglevel() and if it is a bogus value, en error is printed to stderr and the level is clamped to the nearest extreme.

This ticket can be closed.

comment:5 Changed 6 years ago by kean

  • Resolution set to fixed
  • Status changed from reviewing to closed

Verified the above. Closing.

Note: See TracTickets for help on using tickets.