Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#105 closed defect (complete)

REVIEW: path for zone.sqlite3 for xfrin and libauth and auth.spec

Reported by: jreed Owned by: each
Priority: medium Milestone: 04. 2nd Incremental Release: Early Adopters
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: Add Hours to Ticket:
Total Hours: Internal?:

Description

b10-auth supports setting path to zone.sqlite3 in auth.spec using database_file. It is not set.

libauth has a default (if configuration spec didn't have it). This needs to be set to $localstatedir/bind10/zone.sqlite3.

One idea is to get Makefile.am to have a target create another include file that contains just this. (config.h won't work easily because ${prefix} is not expanded.)

loadzone is already fixed to use $localstatedir.

xfrin's spec has old path too. And xfrin.py.in has old path.

Subtickets

Change History (12)

comment:1 in reply to: ↑ description Changed 10 years ago by each

xfrin's spec has old path too. And xfrin.py.in has old path.

xfrin is pretty easy: please review r1516

I'll work on b10-auth next.

comment:2 Changed 10 years ago by each

  • Owner set to shane
  • Status changed from new to assigned

b10-auth is addressed in r1536. Shane said he'd look at it, I shall assign to him...

comment:3 Changed 10 years ago by shane

  • Owner changed from shane to mgraff

comment:4 Changed 10 years ago by mgraff

  • Owner changed from mgraff to each

hot potatoe. Not mine.

comment:5 Changed 10 years ago by each

  • Owner changed from each to UnAssigned

I just noticed this ticket in my list. I gave it to shane several weeks ago because he said on jabber that he'd review it; shane gave it to michael without explaining why; michael gave it to me. Code review procedure fail.

I'm giving it to "UnAssigned?" now. Someone review this please...

comment:6 Changed 10 years ago by shane

  • Owner changed from UnAssigned to shane
  • Status changed from assigned to accepted

Okay, I'll bite.

comment:7 follow-up: Changed 10 years ago by shane

  • Owner changed from shane to each
  • Status changed from accepted to assigned

trunk/src/bin/auth/Makefile.am shouldn't include auth.pre in its CLEANFILES. I see that in trunk we only have auth.spec in CLEANFILES, which is good.

Also, I see that auth.spec is no longer in EXTRA_DIST, but rather in b10_auth_DATA. This is also good.

Other than that, it looks good. I do have a question though. :)

Do we need to split the init() functionality from the constructor? Is this for constructor safety?

comment:8 Changed 10 years ago by jreed

  • Summary changed from path for zone.sqlite3 for xfrin and libauth and auth.spec to REVIEW: path for zone.sqlite3 for xfrin and libauth and auth.spec

comment:9 Changed 10 years ago by shane

  • Milestone changed from 02. Running, functional authoritative-only server to 04. 2nd Incremental Release

comment:10 in reply to: ↑ 7 Changed 10 years ago by each

Replying to shane:

Do we need to split the init() functionality from the constructor? Is this for constructor safety?

I think the idea was to allow a data source to be reinitialized without having to destroy and recreate it. But I'm not sure.... Michael's the one that wrote the original sqlite3 data source code, I just tweaked it.

Is it a problem? Should we open a ticket about it?

comment:11 Changed 10 years ago by shane

  • Resolution set to complete
  • Status changed from assigned to closed

No, this is not a problem, I was just curious to the reasoning.

I consider this review done. I'm closing the ticket, since the code has already been merged (AFAIK).

Jeremy, if this affects the reviewed branch at all, then consider this code reviewed!

comment:12 Changed 9 years ago by shane

  • Component changed from Unclassified to data source
Note: See TracTickets for help on using tickets.