Opened 9 years ago

Closed 9 years ago

#1040 closed enhancement (complete)

Modify log messages

Reported by: stephen Owned by: stephen
Priority: low Milestone: Sprint-20110628
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Same changes as for #1034 but for the message files in src/lib/log.

Subtickets

Change History (11)

comment:1 Changed 9 years ago by stephen

  • Owner set to stephen
  • Status changed from new to assigned

comment:2 Changed 9 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from assigned to reviewing

Also changed prefix of messages generated by the logging component from MSG_ to LOG_, as this more accurately describes the source of the message.

Updated the README file with the changes (as well as include information about using the logging
facility with Python).

comment:3 Changed 9 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:4 Changed 9 years ago by jelte

  • Owner changed from jelte to stephen

looks good.

One minimal comment:

In log_messages.mes:
"Indicative of a programming error, when it started up, BIND10 detected that
the given message ID had been registered by one or more modules."

Shouldn't that first comma be a full stop (or a semicolon)?

comment:5 Changed 9 years ago by stephen

  • Owner changed from stephen to jelte

I've altered the message, but your comment did prompt me to review the message descriptions in detail and I've made a number of changes.

comment:6 Changed 9 years ago by jelte

  • Owner changed from jelte to stephen

Looks good, please merge.

comment:7 Changed 9 years ago by stephen

  • Component changed from Unclassified to logging
  • Estimated Difficulty changed from 0.0 to .5

comment:8 Changed 9 years ago by stephen

  • Owner changed from stephen to UnAssigned

Includes a couple of fixes to Makefile.am's to get the BIND 10 unit tests to work.

comment:9 Changed 9 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:10 Changed 9 years ago by jelte

  • Owner changed from jelte to stephen

Looks good, and distcheck works for me too now.

There is another slightly annoying issue, in that the test /src/lib/log/tests/destination_test.sh keeps failing when you switch branches but don't regenerate them by hand. The same goes for local_file_test.sh and severity_test.sh. Not sure if there is an easy automake target to let config.status update it, but if there is we might want to add that. Certainly not a showstopper though.

If this is out of scope, 1040 can be merged. Still/Again? :)

comment:11 Changed 9 years ago by stephen

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged as commit d7c2d4ab317636ed434265d885a433c8e669db10

Concerning the issue about the update of the shell scripts, ticket #1070 has been created for it.

Note: See TracTickets for help on using tickets.