Opened 9 years ago

Closed 9 years ago

#1035 closed enhancement (complete)

Modify nsas messages

Reported by: stephen Owned by: stephen
Priority: low Milestone: Sprint-20110628
Component: logging Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.5 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Same changes as described in #1034

Subtickets

Change History (6)

comment:1 Changed 9 years ago by stephen

  • Owner set to stephen
  • Status changed from new to assigned

comment:2 Changed 9 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from assigned to reviewing

comment:3 Changed 9 years ago by shane

  • Owner changed from UnAssigned to stephen

In NSAS_WRONG_ANSWER the word "raise" is spelled as "riase".

The NSAS_INVALID_RESPONSE does explains what the NSAS is, but only after using the abbreviation. Probably NSAS should be explained the first time it is presented to the user.

Current message:

The NSAS made a query for a RR for the specified nameserver but received
an invalid response.  Either the success function was called without a
DNS message or the message was invalid on some way. (In the latter case,
the error should have been picked up elsewhere in the processing logic,
hence the raising of the error here.)

This message indicates an internal error in the nameserver address store
component (NSAS) of the resolver.  Please raise a bug report.

Suggested replacement:

The NSAS (nameserver address store - part of the resolver) made a 
query for a RR for the specified nameserver but received an invalid
response.  Either the success function was called without a DNS 
message or the message was invalid on some way. (In the latter case,
the error should have been picked up elsewhere in the processing logic,
hence the raising of the error here.)

This message indicates an internal error in the nameserver address 
store component (NSAS) of the resolver. Please raise a bug report.

In NSAS_SEARCH_ZONE_NS we don't use the abbreviation for some reason. It should probably be the same as everywhere else. Something like this:

A debug message output when a call is made to the NSAS (nameserver 
address store - part of the resolver) to obtain the nameservers for 
the specified zone.

If you think these changes are okay, then you can update the branch and merge with them included. Otherwise please add some comments here and pass this ticket back to me.

comment:4 Changed 9 years ago by stephen

  • Component changed from Unclassified to logging
  • Estimated Difficulty changed from 0.0 to 0.5
  • Owner changed from stephen to shane

Suggest small change to second paragraph of NSAS_INVALID_RESPONSE, as the term NSAS was defined in the first paragraph:

This message indicates an internal error in the NSAS.  Please raise a
bug report.

comment:5 Changed 9 years ago by shane

  • Owner changed from shane to stephen

Looks good. I noticed that the last message in the file also defined NSAS twice. I pushed a change correcting that. If this looks good to you, please merge.

comment:6 Changed 9 years ago by stephen

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged to master in commit 8730224ec6ab50b04360caeb4ea72529574911fd

Note: See TracTickets for help on using tickets.