Opened 8 years ago

Closed 8 years ago

#1022 closed defect (fixed)

b10-auth needs to do init log

Reported by: jinmei Owned by: stephen
Priority: high Milestone: Sprint-20110628
Component: b10-auth Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: High
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 1.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This should be trivial, but right now I don't have time to fully
confirm that, so I'll simply create a ticket.

IMO this should be fixed before the next release, so I'll push it
to the current sprint.

Subtickets

Change History (6)

comment:1 Changed 8 years ago by stephen

  • Owner set to stephen
  • Status changed from new to assigned

comment:2 Changed 8 years ago by stephen

Ready for review. Also included fix for related ticket #1023.

comment:3 Changed 8 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from assigned to reviewing

comment:4 Changed 8 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:5 Changed 8 years ago by vorner

  • Owner changed from vorner to stephen

I added one more line for readability, but otherwise the changes look OK. Please merge (together with #1023 ;-).

But I have two small questions (not stopping from merging, more like higher-level discussion):

  • The negative entry note will not be translater ever, right? Do we want to solve this someday?
  • If the verbose mode is set on, will this be overwritten with configuration? I think command line switches should have precedence over configuration files.

comment:6 Changed 8 years ago by stephen

  • Estimated Difficulty changed from 0.0 to 1
  • Resolution set to fixed
  • Status changed from reviewing to closed

The negative entry note will not be translated ever, right? Do we want to solve this someday?

I think the way to do it would be to have a separate log message for negative entries. I have created ticket #1032 for this.

If the verbose mode is set on, will this be overwritten with configuration? I think command line switches should have precedence over configuration files.

I think you are right. I can imagine that a little bit of work is still needed around that area.

Merged and pushed to master, bf41f8dc2265ca0cd9ffb8b8c11047291e69ca3c

Note: See TracTickets for help on using tickets.